Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11865] Add to instructor help: 'Can I use a different team structure for different sessions?' #11870

Merged
merged 6 commits into from
Jun 30, 2022
Merged

[#11865] Add to instructor help: 'Can I use a different team structure for different sessions?' #11870

merged 6 commits into from
Jun 30, 2022

Conversation

Mcheung7272
Copy link
Contributor

Fixes #11865

Followed the other dropdowns to include this one.
Added a new enum and moved the last qn class to my dropdown.

@damithc
Copy link
Contributor

damithc commented Jun 20, 2022

@Mcheung7272 Thanks for this PR. Can you also provide a screenshot of how it looks, for easier reviewing?

@Mcheung7272
Copy link
Contributor Author

yeah, heres a ss
image

@damithc
Copy link
Contributor

damithc commented Jun 20, 2022

@Mcheung7272 I suggest we retain the Alternative N wording suggested in the issue, to emphasize that the two suggested are alternatives (not steps).

@Mcheung7272
Copy link
Contributor Author

sounds good. I'll add it in

@Mcheung7272
Copy link
Contributor Author

Hows this?

image

@damithc
Copy link
Contributor

damithc commented Jun 21, 2022

@Mcheung7272 I'm fine with this version. Although I'm not sure if ... responses of past sessions. or ... responses to past sessions is more appropriate.

@zhaojj2209
Copy link
Contributor

@Mcheung7272 I'm fine with this version. Although I'm not sure if ... responses of past sessions. or ... responses to past sessions is more appropriate.

Maybe ... view the responses of past sessions?

@zhaojj2209 zhaojj2209 added the s.ToReview The PR is waiting for review(s) label Jun 23, 2022
zhaojj2209
zhaojj2209 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the suggested changes are optional.

@zhaojj2209 zhaojj2209 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Jun 29, 2022
@ziqing26 ziqing26 self-requested a review June 30, 2022 04:14
ziqing26
ziqing26 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! Just kindly update the branch

@ziqing26 ziqing26 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Feature User-facing feature; can be new feature or enhancement to existing feature and removed s.FinalReview The PR is ready for final review labels Jun 30, 2022
@wkurniawan07 wkurniawan07 merged commit 4d1916c into TEAMMATES:master Jun 30, 2022
@wkurniawan07 wkurniawan07 added this to the V8.18.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@ziqing26 ziqing26 ziqing26 approved these changes

Assignees
No one assigned
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.18.0
Development

Successfully merging this pull request may close these issues.

Add to instructor help: 'Can I use a different team structure for different sessions?'
5 participants
@Mcheung7272 @damithc @zhaojj2209 @ziqing26 @wkurniawan07