[#11911] Instructor copying course: Progress bar does not load when no feedback sessions are copied

[domlimm]

Fixes #11911.

Outline of Solution

Previously, when an instructor creates a course by copying another course without any feedback session selected, user gets stuck on the copying and no progress is shown on the progress bar.

The fix is to check if there is any feedback session to copy, else we just need to resolve the Promise and this would update the progress bar as well.

Additionally, shifted out the ProgressBarService update lines as there are code duplications in the above fix and the current implementation (5e50c39).

demo.mp4

[FergusMok]

Thank you for responding so quickly to the issue! Could you also add a video of the fix to your description? Here's also some small suggestions

[domlimm]

Hello @FergusMok! Thanks so much for reviewing this PR! I have added replies to your comments, and will wait for your reply before pushing out the changes.

As for the video, may I ask if there is an example of how the video should be filmed? Is it just how it looks like after fixing or there has to be some explanation/demo?

Thank you again! 😃

[FergusMok]

@domlimm There's no particular format for the video, it's purpose is just for other reviewers / people referencing this PR again in the future to able to quickly understand/visualize what you're trying to accomplish in the PR. It's usually for frontend-related PRs. An example would be #11881!

[domlimm]

@FergusMok I see! I understand. Have updated based on your suggestions and made the necessary changes for your review please. Thank you again!

[FergusMok]

@domlimm LGTM! Thanks for fixing this issue! :)