Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11935] Fix instructors with custom permissions cannot view student list #11940

Merged
merged 11 commits into from
Aug 27, 2022
Merged

[#11935] Fix instructors with custom permissions cannot view student list #11940

merged 11 commits into from
Aug 27, 2022

Conversation

ErnestCuong
Copy link
Contributor

Fixes #11935

The issue is that the student list page only checks for course-wide permission. Even though some instructors may have permission to some sections of the course, the course-wide permission is still set to false. My solution is for the student list page to check for both the course-wide permission and the section-wide permission.

@hhdqirui hhdqirui added the s.ToReview The PR is waiting for review(s) label Aug 21, 2022
zhaojj2209
zhaojj2209 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@zhaojj2209 zhaojj2209 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Aug 23, 2022
NicolasCwy
NicolasCwy approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@NicolasCwy NicolasCwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasCwy NicolasCwy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Aug 27, 2022
@NicolasCwy NicolasCwy merged commit 31414a6 into TEAMMATES:master Aug 27, 2022
ErnestCuong added a commit to ErnestCuong/teammates that referenced this pull request Aug 27, 2022
@ErnestCuong
[TEAMMATES#11935] Fix instructors with custom permissions cannot view…
009aef6 
… student list (TEAMMATES#11940)

* Fix Instructor View Problem
zhaojj2209 pushed a commit that referenced this pull request Aug 30, 2022
@ErnestCuong
[#11839] Fix unusual feedback path causing an assertion failure when …
23e103e 
…downloading results (#11932)

* Add some random things

* Add null checking

* Add comments

* [#11935] Fix instructors with custom permissions cannot view student list (#11940)

* Fix Instructor View Problem

* Update comment

* Update comment
@wkurniawan07 wkurniawan07 added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Dec 25, 2022
@wkurniawan07 wkurniawan07 added this to the V8.20.0 milestone Dec 25, 2022
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report and removed c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasCwy NicolasCwy NicolasCwy approved these changes

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees

@NicolasCwy NicolasCwy

@zhaojj2209 zhaojj2209

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.20.0
Development

Successfully merging this pull request may close these issues.

Instructors with custom permissions cannot view student list
5 participants
@ErnestCuong @NicolasCwy @zhaojj2209 @wkurniawan07 @hhdqirui