[#11737] Instructors reminding non-submitters: instructors are considered non-submitters even if there are no questions for instructors #11989
Conversation
… is an instructor then not adding to the list.
…tructors in FeedbackSessionsLogic
[TEAMMATES#11737] new method to fix the way of find submitters
11737 feedback session submitters
|
Guys, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 14 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 16 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 19 days). 🐌 😢 |
|
Closing due to inactivity. Feel free to reopen the PR if you would like to resume working on it. |
|
Guys, This PR seems to be stalling (no activities for the past 23 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 27 days). 🐌 😢 |
|
Guys, This PR seems to be stalling (no activities for the past 30 days). 🐌 😢 |
Fixes #11737
Outline of Solution
Logic problem I find
Instructors' submitted status is "No" when there is no question for them since the logic of getting non-submitters is that: getting set of students and instructors for a certain sessions, then getting a set of givers who submitted at least one question. The students and instructors who are not in the set of givers will be non-submitters.
How I solve it
I changed the way of finding submitters set. Since your logic of non-submitters is the one who is outside the givers set and those who have zero question in a session will be submitters, so those instructors are considered as givers. Then their submitted status will be "Yes".