[#12043] Navigation menu got collapsed #12057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added flex-nowrap bootstrap class so as to prevent unpredictable wrapping
domlimm
requested changes
Feb 5, 2023
There was a problem hiding this comment.
@NaveenJoyGit thanks for your contribution! i have tested and it looks good. tried on prod too by directly adding flex-nowrap and the bug isn't there. lgtm for this solution!
however, do fix your PR description you're missing Fixes #ISSUE_NUMBER at the top. i see that you've ensured everything in the checklist is completed, that's great! you can remove the checklist, and the contents of your PR should follow under Outline of Solution. For a better picture, you could look at other PRs 👍🏻
samuelfangjw
added
s.ToMerge
samuelfangjw
assigned NaveenJoyGit, domlimm and samuelfangjw and unassigned NaveenJoyGit
weiquu
added a commit
to weiquu/teammates
that referenced
this pull request
Feb 18, 2023
…TES#12057)" This reverts commit feb6d8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12043
Outline of Solution
Added flex-nowrap bootstrap class so as to prevent unpredictable wrapping
Please find below screenshots for reference: