Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12081] User-friendliness: Add labels for numerical scale questions #12148

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[#12081] User-friendliness: Add labels for numerical scale questions #12148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/web/app/components/question-submission-form/question-submission-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ <h2 id="question-details"><b>Question {{ model.questionNumber }}: </b>{{ model.q
[responseDetails]="recipientSubmissionFormModel.responseDetails"
(responseDetailsChange)="triggerRecipientSubmissionFormChange(i, 'responseDetails', $event)"
[isDisabled]="isFormsDisabled"
[recipient]="getRecipientName(recipientSubmissionFormModel.recipientIdentifier)"
></tm-num-scale-question-edit-answer-form>
<tm-mcq-question-edit-answer-form *ngIf="model.questionType === FeedbackQuestionType.MCQ" [questionDetails]="model.questionDetails"
[responseDetails]="recipientSubmissionFormModel.responseDetails"
Expand Down
2 changes: 1 addition & 1 deletion ...estion-types/question-edit-answer-form/num-scale-question-edit-answer-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="form-row text-start">
<div class="col-md-2 col-xs-5">
<input type="number" class="form-control" min="{{ questionDetails.minScale }}" max="{{ questionDetails.maxScale }}" step="{{ questionDetails.step }}" tmDisableWheel
[ngModel]="responseDetails.answer === NUMERICAL_SCALE_ANSWER_NOT_SUBMITTED ? '' : responseDetails.answer" (ngModelChange)="triggerResponseDetailsChange('answer', $event)" [disabled]="isDisabled">
[ngModel]="responseDetails.answer === NUMERICAL_SCALE_ANSWER_NOT_SUBMITTED ? '' : responseDetails.answer" (ngModelChange)="triggerResponseDetailsChange('answer', $event)" [disabled]="isDisabled" [attr.aria-label]="getAriaLabel()">
</div>
<div id="possible-values" class="col-md-9 col-xs-6 text-secondary">
Possible values: {{ possibleValues }}
Expand Down
2 changes: 2 additions & 0 deletions ...sion/session-submission-page/__snapshots__/session-submission-page.component.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,6 +1858,7 @@ exports[`SessionSubmissionPageComponent should snap with feedback session questi
class="col-md-2 col-xs-5"
>
<input
aria-label="Response for Barry Harris"
class="form-control ng-untouched ng-pristine ng-valid"
max="10"
min="1"
Expand Down Expand Up @@ -4527,6 +4528,7 @@ exports[`SessionSubmissionPageComponent should snap with feedback session questi
class="col-md-2 col-xs-5"
>
<input
aria-label="Response for Barry Harris"
class="form-control ng-untouched ng-pristine ng-valid"
max="10"
min="1"
Expand Down