New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12194] Add simple workflow to vet pull requests #12196
Conversation
Hi @zhaojj2209, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this doesn't check the title/pr after it is edited. Is this something we would want?
Github Actions has an @damithc @wkurniawan07 Would appreciate your input on this! |
Have similar thoughts, my opinion is it's ok to leave it as such. Maintainers can still manually verify/edit if there are issues. |
@zhaojj2209 I have no strong opinion on rerun on edit. As you have identified, either one has its own set of pros/cons.
The old bot checks for all 9 acceptable keywords, so it's better to retain the behaviour here. |
Fixes #12194
Part of #11383
Adds simple Github Actions workflow using actions/github-script to check PRs. The bot currently checks for the following:
More checks can be added down the line as and when needed. The bot also only checks PRs that are newly opened/reopened, so as to avoid spam.