Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create feedback response question comment db and logic layer #12198

Conversation

cedricongjh
Copy link
Contributor

Part of #12048

Outline of Solution

Create FeedbackResponseCommentsDb and FeedbackResponseCommentsLogic

/**
* Initialize dependencies for {@code FeedbackResponseCommentsLogic}.
*/
void initLogicDependencies(FeedbackResponseCommentsDb frcDb) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the method initializeDependencies in LogicStarter before we forget

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

Copy link
Member

@hhdqirui hhdqirui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add the remaining methods in subsequent PRs.

@hhdqirui hhdqirui merged commit dfa431e into TEAMMATES:v9-migration Mar 13, 2023
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants