-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12022] [#10623] Update development, troubleshooting, and process documentation #12358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkurniawan07
added
s.ToReview
The PR is waiting for review(s)
c.DevOps
Process-related or build-related improvement and addition
labels
Apr 8, 2023
@samuelfangjw @zhaojj2209 feel free to add more process-related updates to the same branch |
samuelfangjw
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes, thanks for updating the docs!
zhaojj2209
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
wkurniawan07
force-pushed
the
10623-12022-docs
branch
from
April 9, 2023 04:33
af98f4d
to
8a6cc1b
Compare
wkurniawan07
added
s.ToMerge
The PR is approved by all reviewers including final reviewer; ready for merging
and removed
s.ToReview
The PR is waiting for review(s)
labels
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12022, also fixes #10623.
Outline of Solution
Most changes can be derived from the commit messages and original issue description.
index.html
is added to resolve the frequently askedlocalhost:8080 returns 404/403
. This gets overridden if there is an existing front-end bundle.master
, at least for now.GaeSimulation
,GAE Remote API
).We should not need to preserve the issues labelled with
c.Message
ora-DevHelp
to discussions, as almost all of them are already outdated (pre-V8, pre-V7, IDE troubleshooting, etc.) and the few ones still relevant are already covered in the updated troubleshooting guide as well as existing discussions.