Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12022] [#10623] Update development, troubleshooting, and process documentation #12358

Merged
merged 11 commits into from
Apr 9, 2023

Conversation

wkurniawan07
Copy link
Member

@wkurniawan07 wkurniawan07 commented Apr 8, 2023

Fixes #12022, also fixes #10623.

Outline of Solution

Most changes can be derived from the commit messages and original issue description.

  • The default index.html is added to resolve the frequently asked localhost:8080 returns 404/403. This gets overridden if there is an existing front-end bundle.
  • The JDK 17 lint and component tests are only run after pushing to master, at least for now.
  • Aside from the two Powerpoint diagrams finally converted to PUML, there are some parts of the documentation still using raw image even though the PUML counterpart exists. All are now standardized.
    • Also, some parts of the design diagrams are outdated and referring to pre-V8 version (e.g. GaeSimulation, GAE Remote API).

We should not need to preserve the issues labelled with c.Message or a-DevHelp to discussions, as almost all of them are already outdated (pre-V8, pre-V7, IDE troubleshooting, etc.) and the few ones still relevant are already covered in the updated troubleshooting guide as well as existing discussions.

@wkurniawan07 wkurniawan07 added s.ToReview The PR is waiting for review(s) c.DevOps Process-related or build-related improvement and addition labels Apr 8, 2023
@wkurniawan07 wkurniawan07 added this to the V8.27.0 milestone Apr 8, 2023
@wkurniawan07
Copy link
Member Author

@samuelfangjw @zhaojj2209 feel free to add more process-related updates to the same branch

Copy link
Member

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes, thanks for updating the docs!

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wkurniawan07 wkurniawan07 merged commit b763fa9 into master Apr 9, 2023
@wkurniawan07 wkurniawan07 deleted the 10623-12022-docs branch April 9, 2023 05:27
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.DevOps Process-related or build-related improvement and addition s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
3 participants