-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12334] Instructor courses page: fix copy instructors from other courses modal checkbox #12369
[#12334] Instructor courses page: fix copy instructors from other courses modal checkbox #12369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @judith-n, thank you for your pull request!
Functionally, the checkbox now works:
Let's also take the chance to standardise it's appearance, as it is currently different from the other checkboxes throughout the application:
This is most likely due to the form-control
class of the input, which sets the checkbox height and width. Removing the form-control
class from the input that should result in the checkbox looking the same as the rest.
Do make the change and re-request a review!
@cedricongjh thank you so much! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution to TEAMMATES!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #12334