Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12277] Instructor home page: Remove links to video tour #12378

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

anuth212
Copy link
Contributor

@anuth212 anuth212 commented Apr 16, 2023

Fixes #12277

I have deleted both video links mentioned.

UIChange1
UIChange2

@jasonqiu212 jasonqiu212 self-requested a review April 16, 2023 01:59
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for contributing @anuth212

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Apr 16, 2023
@samuelfangjw
Copy link
Member

@anuth212, please attach screenshots showing the UI changes.

@domlimm
Copy link
Contributor

domlimm commented Apr 17, 2023

@anuth212 Samuel meant to add the screenshots in the PR description.

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 19, 2023
@zhaojj2209 zhaojj2209 merged commit fb2a91b into TEAMMATES:master Apr 19, 2023
@anuth212 anuth212 deleted the anuth212-patch-1 branch April 19, 2023 23:10
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
@samuelfangjw samuelfangjw added the c.Bug Bug/defect report label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor home page: Remove links to video tour
5 participants