[#12421] Comments for Responses for Essay Question

[undermyumbrella1]

Fixes #12421

Approach 1:

• make a pr to enable comments for each question type

• involves changing the flag to allow comment for a question type

• involves expanding set of question types that allows comment

• update test to ensure flag returns true

• when all question type allows comment, the 3 points above will be obsolete

• aka everything will be deleted

• checks will no longer be done to check if question type allows for comment
  (as all question allows comment)

Approach 2:

• 1 pr to enable comments for all question type
• removes flag, checker methods to check if a question type allows comment
• the comment logic is done outside the question, so it is universal regardless of qn
• tests is done in one place to check comment logic

I chose approach 2 as it was easier, do let me know if you prefer breaking it down by question type.

• For now, submit responses for ALL questions button, will not save comments
• only submit responses for question 1 button will save comment for qn 1
• this is the same for existing logic that allows comment for mcq/msq question
• This pr is to ensure all question types works the same way as existing logic for mcq/msq
• I will make a seperate pr to address this
• Or would you prefer I do it in this pr?

[github-actions]

Hi @ellaella12, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

• Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

[cedricongjh]

Thank you for the PR!

However, there appears to be errors when I try to submit a feedback response comment on non-MCQ and MRQ question types:

Do fix this and address the other comment regarding testing, thank you!

[undermyumbrella1]

Hi, thank you for the review!

May I check how do i replicate the error message above?
I tried submitting for different qn types and got this

[cedricongjh]

Hi, thank you for the review!

May I check how do i replicate the error message above? I tried submitting for different qn types and got this

HI @ellaella12, I tried again but did not run into the error, so no worries about this!

[cedricongjh]

Hi @ellaella12, there's another thing to consider that I missed out, we need to add in the student's comment in the downloaded result as well:

Click download result:

The csv has Giver comment column for MCQ and MRQ type questions

Do add that in and re-request a review, thank you!

[undermyumbrella1]

Hi sorry about that, I have made a fix, it's working now. Thank you!

TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.1.webm

[zhaojj2209]

Thanks for the fix, great work so far!

One last issue I've managed to uncover: after submitting a feedback response to a distribute points (recipients) question, reloading the page and attempting to submit it again without making any changes will give the following error:

The issue doesn't appear if you make any changes to the response before submitting the response again, and the issue is not present for any other question type.

Let me know if you need more clarifications on when the bug occurs.

This should be the last bug left (crosses fingers), after this the PR should be good to go 💪

Edit: My bad, found one more bug 🙇‍♀️ The response comments are not being submitted when clicking the "Submit Responses to All Questions" button, do look into it.

[undermyumbrella1]

Hi, thank you for the review! Sorry for the numerous bugs. have made a fix for submission without changing answer, by changing QuestionConstraintComponent to check is valid only in ngOnInit() when both the recipientSubmissionForms and questionDetails has initialized.
Originally, the check is valid is called right after recipientSubmissionForms is initialised, so default questionDetails are used = wrong validity check. Is this fix ok?
TEAMMATES - Online Peer Feedback_Evaluation System for Student Team Projects (2).webm

For this Edit: My bad, found one more bug 🙇‍♀️ The response comments are not being submitted when clicking the "Submit Responses to All Questions" button, do look into it.
The comment dated May 28 As for your question regarding the saving of comments when saving all questions, I agree that it should be in a separate PR, with a separate issue to track it.
Or should the change be implemented in this pr?

[zhaojj2209]

For this Edit: My bad, found one more bug 🙇‍♀️ The response comments are not being submitted when clicking the "Submit Responses to All Questions" button, do look into it. The comment dated May 28 As for your question regarding the saving of comments when saving all questions, I agree that it should be in a separate PR, with a separate issue to track it. Or should the change be implemented in this pr?

My bad! This totally slipped my mind. Let's work on it in a separate PR as we discussed previously.

Will review the bug fix this weekend.

[zhaojj2209]

Thank you so much for the work done!

@wkurniawan07 Now that we are allowing feedback response participants to add comments for every question type, should we evaluate whether we should do the same for instructor comments as well? Currently instructors are allowed to add comments on all question types except team contribution.

[damithc]

@wkurniawan07 Now that we are allowing feedback response participants to add comments for every question type, should we evaluate whether we should do the same for instructor comments as well? Currently instructors are allowed to add comments on all question types except team contribution.

@zhaojj2209 Perhaps it is better to leave out team contribution questions from this feature. The values shown to instructors could be different from those shown to students (due to normalizing etc.), so the comments instructors enter could be misleading to students.

[cedricongjh]

LGTM, great work on this!