[#10920] Add testing for sortCoursesBy method in instructor home page. #12440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @YvetteJian, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
…github.com/YvetteJian/teammates into 10920-add-testing-for-instructor-home-page
|
Hi, I did not modified the backend code, however the backend test fail and I have no idea why this happened. Could somebody help me? Thank you ! |
domlimm
reviewed
May 27, 2023
There was a problem hiding this comment.
Looks great! Some changes to be made on code formatting.
Forgot to add:
@YvetteJian Let's change courseTabModels at Line 283 to courses.
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.spec.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.spec.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.spec.ts
Outdated
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.spec.ts
Show resolved
Hide resolved
src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.spec.ts
Show resolved
Hide resolved
…ome-page.component.spec.ts change courseTabModels at Line 283 to courses. Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
…ome-page.component.spec.ts change variable name Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
…ome-page.component.spec.ts change variable name Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
…ome-page.component.spec.ts Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
domlimm
approved these changes
May 30, 2023
domlimm
added
s.FinalReview
samuelfangjw
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10920
Outline of Solution
Add test case for sortCoursesBy()