Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10508] Instructor courses page: some items don't show spinners #12521

Merged
merged 8 commits into from Jul 31, 2023
Merged

[#10508] Instructor courses page: some items don't show spinners #12521

merged 8 commits into from Jul 31, 2023

Conversation

rexong
Copy link
Contributor

@rexong rexong commented Jul 16, 2023 •
edited

Fixes #10508

Outline of Solution

  1. I added alerts for both Archive and Deleted Courses tables on Courses Page and displays them when there are no archive or deleted courses.
    image
  2. I added spinners for Archive and Deleted Courses Tables when the page is still fetching the data.
  3. I also changed the layout of the Active Courses Table to show the table name Active Courses while displaying the spinner.

image

TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.Mozilla.Firefox.2023-07-23.19-57-50.mp4

@github-actions
Copy link

Hi @rexong, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@rexong rexong changed the title Unhide archive and delete table Instructor courses page: some items don't show spinners Jul 16, 2023
@rexong rexong changed the title Instructor courses page: some items don't show spinners [#10508] Instructor courses page: some items don't show spinners Jul 16, 2023
@rexong rexong marked this pull request as ready for review July 23, 2023 11:59
weiquu
weiquu reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rexong, looks great (: Only one small nit: could you change isLoadingSoftDeleteCourses to isLoadingSoftDeletedCourses? I think this is more consistent with the other Loading variables like isLoadingArchivedCourses as well as variables such as softDeletedCourses and softDeletedCourse

@weiquu weiquu added the s.ToReview The PR is waiting for review(s) label Jul 24, 2023
@rexong
Copy link
Contributor Author

rexong commented Jul 27, 2023

Can I check if there is any updates on the E2E Test? I cant seem to pass the E2E test but not sure why.

@weiquu
Copy link
Contributor

weiquu commented Jul 27, 2023

Can I check if there is any updates on the E2E Test? I cant seem to pass the E2E test but not sure why.

I've just merged in a PR that fixes this issue - once you update your branch (and the branch for your other PR), it should be fine

@rexong
Copy link
Contributor Author

rexong commented Jul 28, 2023

I have updated my branch and made the relevant changes. Ready for review.

weiquu
weiquu approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Jul 28, 2023
@rexong
Copy link
Contributor Author

rexong commented Jul 31, 2023

Hello, I think this PR still requires another review? Thank you!

@jasonqiu212 jasonqiu212 self-requested a review July 31, 2023 08:04
jasonqiu212
jasonqiu212 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jul 31, 2023
@jasonqiu212 jasonqiu212 merged commit 37c81b8 into TEAMMATES:master Jul 31, 2023
9 checks passed
@jasonqiu212 jasonqiu212 mentioned this pull request Jul 31, 2023
Closed
@samuelfangjw samuelfangjw added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Aug 21, 2023
@samuelfangjw samuelfangjw added this to the V8.29.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@weiquu weiquu weiquu approved these changes

Assignees

@jasonqiu212 jasonqiu212

@weiquu weiquu

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.29.0
Development

Successfully merging this pull request may close these issues.

Instructor courses page: some items don't show spinners
4 participants
@rexong @weiquu @jasonqiu212 @samuelfangjw