[#12544] Rubric Question Statistics: Handle empty weights

[jasonqiu212]

Fixes #12544

Changes:

• Skip over null weight values when calculating average weight
• Add explanation on usage of empty weights

Screenshots:

• Empty weights are displayed as empty string, as shown in the screenshots below (i.e. [])

Viewing statistics:

• In above screenshot, calculation of average skips over empty weights
  • (7 * 0 + 8 * 10) / 15 = 5.33

• In above screenshot, calculation of average skips over empty weights
  • (1 * 0 + 1 * 10) / 2 = 5

• In above screenshot, calculation of average skips over empty weights
  • (2 * 0 + 2 * 10) / 4 = 5

Downloaded result:

[github-actions]

Hi @jasonqiu212, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

• Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

[weiquu]

Hi @jasonqiu212, I tried to leave the weight input box blank when creating a Rubric question, but am encountering a server error. Can I check if you're facing the error as well? Not sure if there's an issue with my setup. Here's the input (with the error):

Snippet of stack trace:

java.lang.NumberFormatException: empty String
        at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1842)
        at java.base/jdk.internal.math.FloatingDecimal.parseDouble(FloatingDecimal.java:110)
        at java.base/java.lang.Double.parseDouble(Double.java:543)

[jasonqiu212]

@weiquu, Thanks for flagging the issue! I believe it's due to the conversion between null and NO_VALUE. I reverted the empty input to be represented by null. It should work fine now.

[weiquu]

Thanks @jasonqiu212 for the changes! Just one more thing:

For this question, I set all options to have empty weights. I noted two possible areas of improvement:

1. The "Average" (and "Total") columns for Response Summary and Per Recipient Statistics (Per Criterion) should probably indicate that the average is not calculable, given that the answers all have empty weights. I would suggest indicating something like -. What do you think?
2. For the Per Recipient Statistics (Overall), the "Total" and "Per Criterion Average" columns should follow the same indication as above. In addition, the "Average" column should also show the same thing, instead of the NaN it shows now

[jasonqiu212]

@weiquu Yep, I agree! I will work on adding this indication of non-calculable averages (-). Thanks for pointing out this edge case!

[jasonqiu212]

As suggested by @weiquu, I display - to indicate that the aggregate value cannot be calculated when all values are empty.

[weiquu]

LGTM! Thanks for the fix

[domlimm]

@jasonqiu212 @weiquu will get to this today

[domlimm]

LGTM! Very nice job @jasonqiu212! Thank you for fixing this 💯

[damithc]

@samuelfangjw shall we do a new release with this fix?

[damithc]

Fix deployed. Thanks for the fix @jasonqiu212 and @samuelfangjw @domlimm @weiquu for inputs/reviews.