Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12551] Sessions page fix #12561

Merged
merged 7 commits into from Sep 6, 2023
Merged

Conversation

DamiGbs
Copy link
Contributor

@DamiGbs DamiGbs commented Aug 18, 2023

Fixes #12551

Outline of Solution
Did the same as in PR #12550. Only that i added a error Toast:
image

@weiquu
Copy link
Contributor

weiquu commented Aug 19, 2023

Hi @DamiGbs, thanks for submitting this PR. I noted that there are a lot of formatting changes introduced. Do revert those changes in accordance to our documentation, which states under point 3 that "no unrelated changes are [to be] introduced in the branch. This includes unnecessary formatting changes". As far as I can tell, the relevant changes are only to 5 lines.

Do also note that we typically align multi-line parameters to the first parameter (e.g. line 109), or add an additional tab to indicate that the parameter list is still ongoing. When we chain operations together on a variable, we also either align to the first operation or add an additional tab as a visual indicator (e.g. line 164).

We will proceed to review your PR after the changes have been made.

@weiquu weiquu added the s.Ongoing The PR is being worked on by the author(s) label Aug 19, 2023
@DamiGbs
Copy link
Contributor Author

DamiGbs commented Aug 19, 2023

Hi @weiquu, should be fixed now. Looks like i had a different formatter in VsCode that changed the whole formatting of the code.

@cedricongjh cedricongjh self-requested a review August 21, 2023 15:02
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DamiGbs, thank you for your PR, do make the requested changes and re-request for a review!

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution to TEAMMATES

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Aug 22, 2023
@cedricongjh cedricongjh self-assigned this Aug 22, 2023
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 merged commit ceb0bcf into TEAMMATES:master Sep 6, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Bug Bug/defect report and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor Session Page: Failed copy feedback session causes page to load forever.
6 participants