Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12499] Flickering questions when loading session results #12570

Merged
merged 10 commits into from
Sep 15, 2023
Merged

[#12499] Flickering questions when loading session results #12570

merged 10 commits into from
Sep 15, 2023

Conversation

blejkowski
Copy link
Contributor

@blejkowski blejkowski commented Aug 30, 2023 •
edited
Loading

Fixes #12499

Changed the hasResponse field to be false by default. Now the questions won't show up briefly and then be hidden due to not having responses.

Previous:
https://user-images.githubusercontent.com/63457492/247068301-1e5b68cc-5bec-4f07-aa57-e3837ec1847b.mp4

New:
https://github.com/TEAMMATES/teammates/assets/83157275/592b008d-9290-4ecb-b6dc-af993ee0f710

@github-actions
Copy link

Hi @blejkowski, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@blejkowski
Copy link
Contributor Author

Ready for review.

@jasonqiu212 jasonqiu212 added the s.ToReview The PR is waiting for review(s) label Sep 1, 2023
@cedricongjh cedricongjh self-requested a review September 8, 2023 18:50
cedricongjh
cedricongjh approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution to TEAMMATES!

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Sep 8, 2023
@jasonqiu212 jasonqiu212 changed the title [#12499] flickering questions when loading feedback session res… [#12499] Flickering questions when loading session results Sep 9, 2023
@jasonqiu212 jasonqiu212 mentioned this pull request Sep 13, 2023
Closed
jasonqiu212
jasonqiu212 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 merged commit ed3d5f0 into TEAMMATES:master Sep 15, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Flickering questions when loading sessions results
4 participants
@blejkowski @jasonqiu212 @cedricongjh @wkurniawan07