Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12314] Popover appears in front of modal blocking buttons #12573

Conversation

Mex7180
Copy link
Contributor

@Mex7180 Mex7180 commented Sep 4, 2023

Fixes #12314

Outline of Solution

  • add mouse enter event to enable the tooltip
  • close tooltip when the button to save the responses is clicked

Laptop size:
Bildschirmfoto 2023-09-04 um 02 13 40
Bildschirmfoto 2023-09-04 um 02 13 54

Mobile size:
Bildschirmfoto 2023-09-04 um 02 14 16
Bildschirmfoto 2023-09-04 um 02 14 27

@Mex7180 Mex7180 changed the title [#12314] Update: Popover appears in front of modal blocking buttons [#12314] Popover appears in front of modal blocking buttons Sep 4, 2023
@Mex7180
Copy link
Contributor Author

Mex7180 commented Sep 4, 2023

Ready for review :D

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution to TEAMMATES!

@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Sep 4, 2023
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to TEAMMATES! @Mex7180

Just a very small nitpick on the indentation! Other than that, LGTM!

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing to TEAMMATES!

@jasonqiu212 jasonqiu212 merged commit 0e09533 into TEAMMATES:master Sep 13, 2023
9 checks passed
@Mex7180 Mex7180 deleted the #12314-Popover-appears-in-front-of-modal-blocking-buttons branch September 19, 2023 21:07
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover appears in front of modal blocking buttons
4 participants