Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12276] Instructor edit session page: Fix custom visibility table overflow #12574

Conversation

RohithSurya
Copy link
Contributor

Fixes #12276

Outline of Solution
I added a div with the bootstrap class for responsive tables, which adds a horizontal scrollbar when the content is too big.
Added a screenshot to show how it looks.
Screenshot 2023-09-03 at 8 37 38 PM

@RohithSurya
Copy link
Contributor Author

Hey guys!! The fix is ready

Can someone review and approve my changes

@cedricongjh cedricongjh self-requested a review September 8, 2023 19:24
@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Sep 8, 2023
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution, apologies for the delay

Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Sep 16, 2023
@cedricongjh cedricongjh merged commit 4a39df1 into TEAMMATES:master Sep 17, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added the c.Bug Bug/defect report label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor edit session page: Fix custom visibility table overflow
4 participants