Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add unit tests to comment-visibility-setting-pipe #12589

Merged
merged 4 commits into from Sep 25, 2023
Merged

[#12588] Add unit tests to comment-visibility-setting-pipe #12589

merged 4 commits into from Sep 25, 2023

Conversation

cedricongjh
Copy link
Contributor

@cedricongjh cedricongjh commented Sep 20, 2023 •
edited

Part of #12588

Outline of Solution
Create unit tests for the pipes in comment-visibility-setting-pipe.ts

@cedricongjh cedricongjh changed the title Add unit tests to comment-visibility-setting-pipe [#12588] Add unit tests to comment-visibility-setting-pipe Sep 20, 2023
@TEAMMATES TEAMMATES deleted a comment from github-actions bot Sep 20, 2023
@cedricongjh cedricongjh mentioned this pull request Sep 20, 2023
Open
@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Sep 20, 2023
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Open
jasonqiu212
jasonqiu212 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Sep 22, 2023
@cedricongjh cedricongjh merged commit be905b6 into TEAMMATES:master Sep 25, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cedricongjh @jasonqiu212 @wkurniawan07