Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12588] Add unit tests to copy course modal component #12590

Merged

Conversation

cedricongjh
Copy link
Contributor

@cedricongjh cedricongjh commented Sep 20, 2023

Part of #12588

Outline of Solution
Added unit tests to CopyCourseModalComponent

Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Sep 22, 2023
@jasonqiu212 jasonqiu212 merged commit a1e2ca5 into TEAMMATES:master Sep 25, 2023
9 checks passed
MaharshiPedu pushed a commit to MaharshiPedu/teammates that referenced this pull request Sep 26, 2023
jasonqiu212 pushed a commit that referenced this pull request Sep 29, 2023
…button to download results by question (#12591)

* Added separate button to download results by question

* Removed download functionality from question number

* �[200~

* Changed the color of chevron

* Fixed lint issues

* add unit tests to copy course modal component (#12590)

* Fixed lint issues

* added color of chevron during panel expansion

* Updated snapshots

* Stopped propogation of download btn and removed showDownload functionality

* Updated question-text-with-info snapshot

---------

Co-authored-by: Maharshi Pandya <pandyamaharshi2001@gmail.com>
Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants