Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add unit tests to DatePickerFormatter #12593

Merged
merged 4 commits into from Sep 26, 2023
Merged

[#12588] Add unit tests to DatePickerFormatter #12593

merged 4 commits into from Sep 26, 2023

Conversation

dlimyy
Copy link
Contributor

@dlimyy dlimyy commented Sep 25, 2023

Part of #12588

Outline of Solution
Added unit tests for the methods in DatePickerFormatter.

cedricongjh
cedricongjh approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a small nit

src/web/app/components/datepicker/datepicker-formatter.spec.ts Outdated Show resolved Hide resolved
@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Sep 25, 2023
@cedricongjh cedricongjh mentioned this pull request Sep 25, 2023
Open
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Open
jasonqiu212
jasonqiu212 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Sep 26, 2023
@jasonqiu212 jasonqiu212 merged commit 70be153 into TEAMMATES:master Sep 26, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dlimyy @jasonqiu212 @cedricongjh @wkurniawan07