Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Added unit tests to CourseEditForm component. #12597

Merged
merged 9 commits into from
Oct 18, 2023
Merged

[#12588] Added unit tests to CourseEditForm component. #12597

merged 9 commits into from
Oct 18, 2023

Conversation

lunoos
Copy link
Contributor

@lunoos lunoos commented Oct 1, 2023 •
edited by jasonqiu212
Loading

Part of #12588

Outline of Solution
Added unit tests to CourseEditForm component for following methods:
setIsEditing,
updateInstitutes,
detectTimezoneHandler,
submitHandler,
closeFormHandler,
deleteCourseHandler

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Hi @lunoos, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@lunoos lunoos changed the title 12588 improve test code coverage of core components [#12588] improve test code coverage of core components Oct 1, 2023
@lunoos lunoos changed the title [#12588] improve test code coverage of core components [#12588] Added unit tests to CourseEditForm component. Oct 1, 2023
jasonqiu212
jasonqiu212 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Oct 1, 2023
@cedricongjh cedricongjh self-requested a review October 2, 2023 13:31
cedricongjh
cedricongjh requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits, and also do add tests for the statusMessageService.showErrorToast being called in copyCourseHandler

src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
@cedricongjh cedricongjh mentioned this pull request Oct 4, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Open
@lunoos
Copy link
Contributor Author

lunoos commented Oct 8, 2023

some small nits, and also do add tests for the statusMessageService.showErrorToast being called in copyCourseHandler

Changes made

cedricongjh
cedricongjh requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lunoos thanks for the effort here, i've added a few more comments, do take a look and make the necessary changes

src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/course-edit-form/course-edit-form.component.spec.ts Outdated Show resolved Hide resolved
@lunoos
Copy link
Contributor Author

lunoos commented Oct 17, 2023

Changes has been made

cedricongjh
cedricongjh approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for your contribution to TEAMMATES

@cedricongjh cedricongjh merged commit 3bdbef9 into TEAMMATES:master Oct 18, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh added a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@lunoos @cedricongjh
[TEAMMATES#12588] Added unit tests to CourseEditForm component. (TEAM…
eb037f4 
…MATES#12597)

* [TEAMMATES#12588] Added unit tests to CourseEditForm component

* [TEAMMATES#12588] Added unit tests to CourseEditForm component

* [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component

* [TEAMMATES#12588] Added unit tests to CourseEditForm component

* [TEAMMATES#12588] Added unit tests to CourseEditForm component

* [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component

* [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component

---------

Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@jasonqiu212 jasonqiu212

@cedricongjh cedricongjh

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunoos @jasonqiu212 @cedricongjh @wkurniawan07