Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12599] fixes typo error #12600

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[#12599] fixes typo error #12600

merged 1 commit into from
Oct 5, 2023

Conversation

Technmad
Copy link
Contributor

@Technmad Technmad commented Oct 4, 2023

Fixes #12599

Outline of Solution
added "the" within the paragraph for better readability

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hi @Technmad, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@Technmad Technmad changed the title fixes typo error [#12599] fixes typo error Oct 4, 2023
@weiquu
Copy link
Contributor

weiquu commented Oct 5, 2023

Hi @Technmad, thanks for the fix! For future PRs, do note that our docs mention (under point 3) that no unrelated changes are to be introduced in the branch, including unnecessary formatting changes.

weiquu
weiquu approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Oct 5, 2023
@cedricongjh cedricongjh self-requested a review October 5, 2023 08:14
cedricongjh
cedricongjh approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cedricongjh cedricongjh merged commit 62139bc into TEAMMATES:master Oct 5, 2023
10 checks passed
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Typo in the "CONTRIBUTING.md"
4 participants
@Technmad @weiquu @cedricongjh @wkurniawan07