Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add unit test for every method in CommentEditFormComponent #12604

Merged
merged 9 commits into from
Nov 30, 2023
Merged

[#12588] Add unit test for every method in CommentEditFormComponent #12604

merged 9 commits into from
Nov 30, 2023

Conversation

HarryLu33
Copy link
Contributor

@HarryLu33 HarryLu33 commented Oct 12, 2023 •
edited by weiquu
Loading

Part of #12588

Outline of Solution
Add unit test for every method in CommentEditFormComponent

@github-actions
Copy link

Hi @HarryLu33, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@HarryLu33 HarryLu33 changed the title Add unit test for every method in CommentEditFormComponent [#12588] Add unit test for every method in CommentEditFormComponent Oct 14, 2023
@HarryLu33
Copy link
Contributor Author

Ready for review

@cedricongjh cedricongjh self-requested a review October 14, 2023 19:19
@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Oct 14, 2023
cedricongjh
cedricongjh reviewed Oct 14, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for for the PR!

in addition to my comments, let's add a test for the ngOnInit() method, when the component is initialized with a response as well

src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.spec.ts Outdated Show resolved Hide resolved
HarryLu added 3 commits October 15, 2023 15:01
spys assigned to a const
83d102d 
 comments removed
 added test for the ngOnInit() method
fix code style
e0bfb1c
fix code style
4a410cd
@HarryLu33
Copy link
Contributor Author

Changes made
Ready for review

cedricongjh
cedricongjh approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for your work on this!

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Oct 16, 2023
@cedricongjh cedricongjh mentioned this pull request Oct 18, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Open
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢
Hope someone can get it to move forward again soon...

weiquu
weiquu approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu removed the request for review from jasonqiu212 November 30, 2023 06:12
@weiquu weiquu added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Nov 30, 2023
@weiquu weiquu merged commit 3fb5fa9 into TEAMMATES:master Nov 30, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@HarryLu33 @weiquu @cedricongjh
[TEAMMATES#12588] Add unit test for every method in CommentEditFormCo…
491dd37 
…mponent (TEAMMATES#12604)

* add unit test for every method in CommentEditFormComponent

* fix errors

* delete empty line

* spys assigned to a const
 comments removed
 added test for the ngOnInit() method

* fix code style

* fix code style

---------

Co-authored-by: HarryLu <harrry.lu@tennentgroup.com.au>
Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HarryLu33 @nusoss-bot @weiquu @cedricongjh @wkurniawan07