[#12588] Added unit tests for CommentTableModalComponent #12609
Conversation
…ttps://github.com/kenneySiu/teammates into 12588-Improve-test-code-coverage-of-core-components
| const testModel: CommentTableModel = { | ||
| commentRows: [], | ||
| newCommentRow: { | ||
| commentEditFormModel: { | ||
| commentText: '', | ||
| isUsingCustomVisibilities: false, | ||
| showCommentTo: [], | ||
| showGiverNameTo: [], | ||
| }, | ||
| isEditing: true, | ||
| }, | ||
| isAddingNewComment: false, | ||
| isReadOnly: false, | ||
| }; |
There was a problem hiding this comment.
let's abstract this out for multiple tests to use
| }); | ||
| }); | ||
|
|
||
| it('should trigger an event to delete comment from comments table', () => { |
There was a problem hiding this comment.
| it('should trigger an event to delete comment from comments table', () => { | |
| it('should emit a DeleteCommentEvent with the correct index when triggerDeleteCommentEvent is called', () => { |
let's follow this format when describing tests for event emissions, do the same for the other tests that emit events
…ttps://github.com/kenneySiu/teammates into 12588-Improve-test-code-coverage-of-core-components
|
Ready for review |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
1 similar comment
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 10 days). 🐌 😢 |
wkurniawan07
added
s.ToMerge
…AMMATES#12609) * Added unit tests to CommentTableModal Component * Fixed test for CommentTableModalComponent * Fixed test for CommentTableModalComponent * fix import on comment-table-modal-compenent tests * Made changes to CommentTableModalComponent tests * Delete space on comment-table-modal.component tests * Added Unit test for sessionEditFormComponent * reverted sessionEditFormComponent tests * fixed issues on session-edit-form-component tests * fixed spacing on sessioneditformcomponent tests * fixed spacing on sessioneditformcomponent tests --------- Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Part of #12588
Outline of Solution
Added unit tests for the following methods in CommentTableModalComponent
ngOnChanges,
triggerDeleteCommentEvent,
triggerUpdateCommentEvent,
triggerSaveNewCommentEvent,
triggerModelChange