[#12588] Improve test code coverage of CopySessionModalComponent #12616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od from partial covered to all covered for CopySessionModalComponent.
…ponent' into add-tests-to-CopySessionModalComponent # Conflicts: # src/web/app/components/copy-session-modal/copy-session-modal.component.spec.ts
|
Hi @Astrid641, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
cedricongjh
requested changes
Oct 21, 2023
src/web/app/components/copy-session-modal/copy-session-modal.component.spec.ts
Outdated
Show resolved
Hide resolved
|
Changes made |
cedricongjh
approved these changes
Oct 22, 2023
cedricongjh
added
s.FinalReview
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
weiquu
added
s.ToMerge
wkurniawan07
added
the
c.Task
cedricongjh
pushed a commit
to cedricongjh/teammates
that referenced
this pull request
Feb 20, 2024
…nent (TEAMMATES#12616) * commit to checkout * Add test for the 'copy' method and improve the test for 'select' method from partial covered to all covered for CopySessionModalComponent. * remove blank line * add new line at the end of file * removed the old test which running error in CI test * revert the change of spec.ts.snap --------- Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12588
Outline of Solution
Add test for the 'copy' method and improve the test for 'select' method from partial covered to all covered for CopySessionModalComponent.