Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add some unit test in recipient-type-name #12626

Merged
merged 4 commits into from
Dec 2, 2023
Merged

[#12588] Add some unit test in recipient-type-name #12626

merged 4 commits into from
Dec 2, 2023

Conversation

ThomasGreen123
Copy link
Contributor

Fixes [https://github.com//issues/12588]

Outline of Solution
Add unit test for every method in recipient-type-name in question submission form

@github-actions
Copy link

Hi @ThomasGreen123, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@ThomasGreen123 ThomasGreen123 changed the title [#12588] Add some unit test in recipient-type-name.pipe.spec.ts [#12588] Add some unit test in recipient-type-name Oct 27, 2023
@ThomasGreen123
Copy link
Contributor Author

Hi, I think class Question-Submission-Form's work load is a bit high and is difficult for me to manage it effectively. But I've complete all the test in recipient-type-name. Ready to review.

cedricongjh
cedricongjh approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR

@cedricongjh cedricongjh mentioned this pull request Oct 28, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 28, 2023
Open
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

@cedricongjh cedricongjh merged commit 33bcd77 into TEAMMATES:master Dec 2, 2023
9 checks passed
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 13 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 16 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 20 days). 🐌 😢
Hope someone can get it to move forward again soon...

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh added a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@ThomasGreen123 @cedricongjh
[TEAMMATES#12588] Add some unit test in recipient-type-name (TEAMMATE…
96c6c18 
…S#12626)

* [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts

* [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts

* [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts

---------

Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThomasGreen123 @nusoss-bot @cedricongjh @wkurniawan07