[#12588] Added unit tests for SessionEditFormComponent #12627

kenneySiu · 2023-10-27T10:37:46Z

Outline of Solution
Added unit tests for the following methods in SessionEditFormComponent
triggerModelChange,
triggerSubmissionOpeningDateModelChange,
courseIdChangeHandler,
submitFormHandler,
cancelHandler,
deleteHandler,
copyHandler,
copyOthersHandler,
closeEditFormHandler

cedricongjh

some changes,

also minTimeForSubmissionEnd, minDateForSessionVisible, minTimeForSessionVisible, maxDateForSessionVisible, maxTimeForSessionVisible, minDateForResponseVisible, minTimeForResponseVisible are currently not tested as well, do add tests for those

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

cedricongjh · 2023-10-28T19:17:59Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+  it('should emit a cancelEditingSession event after modal confimation', async () => {
+    jest.spyOn((component as any).simpleModalService, 'openConfirmationModal').mockReturnValue(mockModal);
+    const cancelEditingSessionSpy = jest.spyOn(component.cancelEditingSessionEvent, 'emit');
+    component.cancelHandler();
+    await mockModal.result;
+    expect(cancelEditingSessionSpy).toHaveBeenCalled();
+  });
+
+  it('should emit a deleteExistingSession event after modal confimation', async () => {
+    jest.spyOn((component as any).simpleModalService, 'openConfirmationModal').mockReturnValue(mockModal);
+    const deleteExistingSessionSpy = jest.spyOn(component.deleteExistingSessionEvent, 'emit');
+    component.deleteHandler();
+    await mockModal.result;
+    expect(deleteExistingSessionSpy).toHaveBeenCalled();
+  });


for these methods, we should be creating a modalSpy and checking if it's called with the appropriate params, you can see admin-notifications-page.component.spec.ts for an example

…nneySiu/teammates into 12588-session-edit-form-tests

kenneySiu · 2023-10-29T03:59:10Z

Added additional tests
Ready for review

cedricongjh

thanks for adding the new tests, left a few comments!

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

cedricongjh · 2023-10-30T09:32:27Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

 import { SessionEditFormComponent } from './session-edit-form.component';
 import { SessionEditFormModule } from './session-edit-form.module';

 describe('SessionEditFormComponent', () => {
  let component: SessionEditFormComponent;
  let fixture: ComponentFixture<SessionEditFormComponent>;
+  let simpleModalService: SimpleModalService;
+  let service: DateTimeService;


nit: let's rename this dateTimeService for better readability

cedricongjh · 2023-10-30T09:33:17Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+    component.model.submissionStartDate = date;
+    component.model.submissionStartTime = time;
+    const minTimeForSubmissionEnd = component.minTimeForSubmissionEnd;
+    expect(minTimeForSubmissionEnd).toStrictEqual(time);


nit: let's just use component.minTimeForSubmissionEnd here instead of the const

cedricongjh · 2023-10-30T09:42:19Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+    component.model.submissionStartDate = date;
+    component.model.submissionStartTime = time;
+    const minTimeForSubmissionEnd = component.minTimeForSubmissionEnd;
+    expect(minTimeForSubmissionEnd).toStrictEqual(oneHourBeforeNow);


same here, use component.minTimeForSubmissionEnd directly, do make the changes for all the others below

cedricongjh · 2023-10-30T09:57:38Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+      + 'when response visible setting is CUSTOM and submissionStartDate is before customResponseVisibleDate', () => {
+    component.model.responseVisibleSetting = ResponseVisibleSetting.CUSTOM;
+    component.model.submissionStartDate =
+        service.getDateInstance(moment().tz(component.model.timeZone));


let's save moment().tz(component.model.timeZone) into a const here, as unlikely as it may be, there might be a case where the date changes while the test runs and thus it might end up as different days

cedricongjh · 2023-10-30T10:00:33Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+      + 'when response visible setting is CUSTOM and submissionStartDate is after customResponseVisibleDate', () => {
+    component.model.responseVisibleSetting = ResponseVisibleSetting.CUSTOM;
+    component.model.submissionStartDate =
+        service.getDateInstance(moment().tz(component.model.timeZone).add(1, 'days'));


same as above here

cedricongjh · 2023-10-30T10:02:27Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+    component.model.responseVisibleSetting = ResponseVisibleSetting.CUSTOM;
+    component.model.submissionStartTime =
+        service.getTimeInstance(moment());
+    component.model.customResponseVisibleTime =
+        service.getTimeInstance(moment());
+    component.model.submissionStartDate =
+        service.getDateInstance(moment().tz(component.model.timeZone));
+    component.model.customResponseVisibleDate =
+        service.getDateInstance(moment().tz(component.model.timeZone).add(1, 'days'));


same here, let's save all the moment() calls into a const instead

cedricongjh · 2023-10-30T10:02:39Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+    component.model.submissionStartTime =
+        service.getTimeInstance(moment());
+    component.model.customResponseVisibleTime =
+        service.getTimeInstance(moment());
+    component.model.submissionStartDate =
+        service.getDateInstance(moment().tz(component.model.timeZone).add(1, 'days'));
+    component.model.customResponseVisibleDate =
+        service.getDateInstance(moment().tz(component.model.timeZone));
+    const maxTimeForSessionVisible = component.maxTimeForSessionVisible;


same as above here

cedricongjh · 2023-10-30T10:04:49Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+        service.getDateInstance(moment().tz(component.model.timeZone));
+    component.model.customSessionVisibleDate =
+        service.getDateInstance(moment().tz(component.model.timeZone));


we should make customerSessionVisibleDate different from submissionStartDate here

cedricongjh · 2023-10-30T10:05:47Z

src/web/app/components/session-edit-form/session-edit-form.component.spec.ts

+        service.getTimeInstance(moment().tz(component.model.timeZone));
+    component.model.customSessionVisibleTime =
+        service.getTimeInstance(moment().tz(component.model.timeZone));


same here, let's make the customSessionVisibleTime different from submissionStartTime

…nneySiu/teammates into 12588-session-edit-form-tests

kenneySiu · 2023-10-30T11:08:27Z

Ready for review

cedricongjh

LGTM! thank you for your work on this!

nusoss-bot · 2023-11-08T14:50:55Z

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

nusoss-bot · 2023-11-15T15:35:24Z

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

nusoss-bot · 2023-11-27T13:29:11Z

Folks, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢
Hope someone can get it to move forward again soon...

weiquu

LGTM

…MATES#12627) * Added unit tests for session-edit-form-component * Added unit tests for session-edit-form-component * added changes to sessioneditformcomponent tests * fixed indent on seesioneditformcomponent tests * moved test in sessioneditformcomponent * made changes to session edit form tests * fixed issues on session edit form component --------- Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>

kenneySiu and others added 3 commits October 27, 2023 18:46

Added unit tests for session-edit-form-component

ee741e1

Added unit tests for session-edit-form-component

9bdac69

Merge branch 'master' into 12588-session-edit-form-tests

8b38440

cedricongjh requested changes Oct 28, 2023

View reviewed changes

kenneySiu added 2 commits October 29, 2023 14:56

added changes to sessioneditformcomponent tests

71f5ba9

Merge branch '12588-session-edit-form-tests' of https://github.com/ke…

c3a9d53

…nneySiu/teammates into 12588-session-edit-form-tests

kenneySiu added 3 commits October 29, 2023 15:29

fixed indent on seesioneditformcomponent tests

80599c2

moved test in sessioneditformcomponent

2b7921f

Merge branch 'master' into 12588-session-edit-form-tests

9d29348

cedricongjh requested changes Oct 30, 2023

View reviewed changes

kenneySiu added 3 commits October 30, 2023 22:05

made changes to session edit form tests

f7159f1

Merge branch '12588-session-edit-form-tests' of https://github.com/ke…

dc9eaba

…nneySiu/teammates into 12588-session-edit-form-tests

fixed issues on session edit form component

fe25c7a

cedricongjh approved these changes Nov 1, 2023

View reviewed changes

cedricongjh self-assigned this Nov 1, 2023

cedricongjh added the s.FinalReview The PR is ready for final review label Nov 1, 2023

cedricongjh mentioned this pull request Nov 1, 2023

Improve test code coverage of core components #12588

Open

github-actions bot mentioned this pull request Nov 1, 2023

[teammates/TEAMMATES] Issues Digest damithc/digest-test#3

Open

Merge branch 'master' into 12588-session-edit-form-tests

264bfaf

weiquu approved these changes Dec 5, 2023

View reviewed changes

weiquu merged commit 77631b1 into TEAMMATES:master Dec 5, 2023
9 checks passed

wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024

wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#12588] Added unit tests for SessionEditFormComponent #12627

[#12588] Added unit tests for SessionEditFormComponent #12627

kenneySiu commented Oct 27, 2023

cedricongjh left a comment

cedricongjh Oct 28, 2023

kenneySiu commented Oct 29, 2023

cedricongjh left a comment

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

cedricongjh Oct 30, 2023

kenneySiu commented Oct 30, 2023

cedricongjh left a comment

nusoss-bot commented Nov 8, 2023

nusoss-bot commented Nov 15, 2023

nusoss-bot commented Nov 27, 2023

weiquu left a comment

[#12588] Added unit tests for SessionEditFormComponent #12627

[#12588] Added unit tests for SessionEditFormComponent #12627

Conversation

kenneySiu commented Oct 27, 2023

cedricongjh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenneySiu commented Oct 29, 2023

cedricongjh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenneySiu commented Oct 30, 2023

cedricongjh left a comment

Choose a reason for hiding this comment

nusoss-bot commented Nov 8, 2023

nusoss-bot commented Nov 15, 2023

nusoss-bot commented Nov 27, 2023

weiquu left a comment

Choose a reason for hiding this comment