Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12665] Instructor's Student Records Page: Misleading name for canceling of comment edit #12667

Merged
merged 1 commit into from Dec 19, 2023
Merged

[#12665] Instructor's Student Records Page: Misleading name for canceling of comment edit #12667

merged 1 commit into from Dec 19, 2023

Conversation

abdqudus
Copy link
Contributor

@abdqudus abdqudus commented Dec 16, 2023 •
edited

Fixes #12665
This pull request addresses misleading name for canceling of comment edit reported in #12665 .
The changes include changing the button that conditionally displays "Discard" or "Cancel " to only display "Cancel"

@abdqudus
Update comment-edit-form.component.html
c18b627 
In the comment edit form, change the button that conditionally displays "Discard" or "Cancel " to only display "Cancel"
@github-actions GitHub Actions
Copy link

Hi @abdqudus, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@abdqudus abdqudus closed this Dec 16, 2023
@abdqudus abdqudus reopened this Dec 16, 2023
@github-actions GitHub Actions
Copy link

Hi @abdqudus, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@abdqudus
Copy link
Contributor Author

Updated my PR to follow the contribution guideline.

@abdqudus
Copy link
Contributor Author

Updated PR title

@abdqudus abdqudus changed the title Update comment-edit-form.component.html [#12665] Instructor's Student Records Page: Misleading name for canceling of comment edit Dec 16, 2023
@weiquu weiquu added the s.ToReview The PR is waiting for review(s) label Dec 16, 2023
weiquu
weiquu approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Dec 17, 2023
@abdqudus abdqudus closed this Dec 17, 2023
@weiquu
Copy link
Contributor

weiquu commented Dec 18, 2023

Hi @abdqudus - do re-open the PR if you're still interested in us merging it in! Else, we will open this issue up to others.

@abdqudus abdqudus reopened this Dec 18, 2023
@abdqudus
Copy link
Contributor Author

Updated fix #12665

domlimm
domlimm approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Dec 19, 2023
@domlimm domlimm merged commit c1b3d62 into TEAMMATES:master Dec 19, 2023
28 checks passed
@Tejasker Tejasker mentioned this pull request Dec 20, 2023
Merged
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@wkurniawan07 wkurniawan07 added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Jan 21, 2024
@wkurniawan07 wkurniawan07 modified the milestones: V8.29.0, V8.30.0 Jan 21, 2024
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report and removed c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Jan 26, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@abdqudus @cedricongjh
Update comment-edit-form.component.html (TEAMMATES#12667)
9707eea 
In the comment edit form, change the button that conditionally displays "Discard" or "Cancel " to only display "Cancel"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlimm domlimm domlimm approved these changes

@weiquu weiquu weiquu approved these changes

@jasonqiu212 jasonqiu212 Awaiting requested review from jasonqiu212

@cedricongjh cedricongjh Awaiting requested review from cedricongjh

Assignees

@domlimm domlimm

@weiquu weiquu

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Instructor's Student Records Page: Misleading name for canceling of comment edit
5 participants
@abdqudus @weiquu @nusoss-bot @domlimm @wkurniawan07