[#12668] Instructor's Student Records Page: Feedback session panel chevron barely visible #12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiquu
requested changes
Dec 20, 2023
| @@ -6,7 +6,7 @@ <h2>Records in feedback sessions</h2> | |||
| <div class="card-header cursor-pointer" (click)="session.isCollapsed = !session.isCollapsed"> | |||
| <strong class="text-break">Feedback Session: {{ session.feedbackSession.feedbackSessionName }}</strong> | |||
| <div class="card-header-btn-toolbar"> | |||
| <tm-panel-chevron [isExpanded]="!session.isCollapsed"></tm-panel-chevron> | |||
| <tm-panel-chevron [isExpanded]="!session.isCollapsed" [chevronColor]="'black'"></tm-panel-chevron> | |||
There was a problem hiding this comment.
I think let's just go with chevronColor="black" without the [] property binding, since we are just assigning a static value (this is also aligned with the instructor-session-result-question-view component)
|
Updated the PR as per the review suggestions. I've changed the chevron color assignment to a static value ( |
jasonqiu212
approved these changes
Dec 22, 2023
jasonqiu212
changed the title
wkurniawan07
added
s.ToMerge
cedricongjh
pushed a commit
to cedricongjh/teammates
that referenced
this pull request
Feb 20, 2024
…panel chevron barely visible TEAMMATES#12668 (TEAMMATES#12673) * Fix chevron color issue * Replace property binding with static value assignation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12668
Outline of Solution
In this PR, I've updated the color of the
tm-panel-chevronfrom white to black. This change aims to improve the visibility of the chevron on white backgrounds, based on the feedback and suggestions from the community.Changes made:
chevronColorinPanelChevronComponentto black.I've tested this change and believe it enhances the visibility of the chevron without impacting other design aspects. I'm open to any further suggestions or feedback.