Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12654] Instructor Edit Session Page: Bug in Grace Period Tooltip #12675

Merged
merged 6 commits into from
Dec 25, 2023
Merged

[#12654] Instructor Edit Session Page: Bug in Grace Period Tooltip #12675

merged 6 commits into from
Dec 25, 2023

Conversation

nknguyenhc
Copy link
Contributor

Fixes #12654

Outline of Solution

  • Move the tooltip target from the wrapping div of Grace period label to the label itself.
  • Apply the class ngb-tooltip-class to the label, to apply the underline styling.

image

@weiquu
Copy link
Contributor

weiquu commented Dec 22, 2023

Hi @nknguyenhc, do fix the failing checks before we do a review. The snapshot tests can be updated by running npm run test and pressing a to run all test cases. After that, check through the snapshots to make sure the changes are as expected, then press u to update them. You can find more details on snapshot testing here.

@nknguyenhc
Copy link
Contributor Author

I have updated the test cases. Do let me know if there is anything else I need to address!

weiquu
weiquu approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Dec 23, 2023
domlimm
domlimm approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@domlimm domlimm added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Dec 25, 2023
@jasonqiu212 jasonqiu212 merged commit a64f660 into TEAMMATES:master Dec 25, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added the c.Bug Bug/defect report label Jan 21, 2024
@wkurniawan07 wkurniawan07 modified the milestones: V8.29.0, V8.30.0 Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@nknguyenhc @weiquu
@domlimm @cedricongjh
[TEAMMATES#12654] Instructor Edit Session Page: Bug in Grace Period T…
94c22f6 
…ooltip (TEAMMATES#12675)

* Fix grace period tooltip

* Update test cases

---------

Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlimm domlimm domlimm approved these changes

@weiquu weiquu weiquu approved these changes

Assignees
No one assigned
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.

Instructor Edit Session Page: Bug in Grace Period Tooltip
5 participants
@nknguyenhc @weiquu @domlimm @wkurniawan07 @jasonqiu212