Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Add unit tests for visibility panel #12868

Merged
merged 18 commits into from
Mar 12, 2024
Merged

[#12588] Add unit tests for visibility panel #12868

merged 18 commits into from
Mar 12, 2024

Conversation

Andy-W-Developer
Copy link
Contributor

@Andy-W-Developer Andy-W-Developer commented Mar 6, 2024 •
edited
Loading

Part of #12588

Outline of Solution
Add unit test to

  • triggerCustomVisibilitySetting
  • getCheckboxAriaLabel
  • applyCommonVisibilitySettings
  • modifyVisibilityControl.

modifyVisibilityControl tests
Test all cases in the allowToSee and disallowToSee functions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Hi @Andy-W-Developer, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@Andy-W-Developer Andy-W-Developer marked this pull request as ready for review March 7, 2024 15:36
@domlimm domlimm added the s.ToReview The PR is waiting for review(s) label Mar 10, 2024
@cedricongjh cedricongjh self-requested a review March 11, 2024 17:59
cedricongjh
cedricongjh approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@cedricongjh cedricongjh added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 11, 2024
@cedricongjh cedricongjh mentioned this pull request Mar 11, 2024
Open
@weiquu weiquu merged commit d32c2cb into TEAMMATES:master Mar 12, 2024
10 of 11 checks passed
@Andy-W-Developer Andy-W-Developer deleted the add-unit-test-to-visibility-panel branch March 14, 2024 02:44
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andy-W-Developer @cedricongjh @domlimm @weiquu