Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Revert getFilterQuery for Account Data Migration Script #12887

Merged
merged 1 commit into from Mar 12, 2024
Merged

[#12048] Revert getFilterQuery for Account Data Migration Script #12887

merged 1 commit into from Mar 12, 2024

Conversation

ziqing26
Copy link
Contributor

Part of #12048

Outline of Solution

  • Revert the getFilterQuery to not filter by isMigrated, instead check this flag in isMigrationNeeded method.
  • Seed account with the isMigrated check to be false.

NicolasCwy
NicolasCwy approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@NicolasCwy NicolasCwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziqing26 ziqing26 merged commit 7668295 into TEAMMATES:master Mar 12, 2024
11 of 12 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasCwy NicolasCwy NicolasCwy approved these changes

@cedricongjh cedricongjh Awaiting requested review from cedricongjh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V9.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ziqing26 @NicolasCwy @cedricongjh