[#12048] Patch Usage Statistics Migration #12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SQL query to patch the data migration script
|
One problem with the patching right now is that we still have to scan through all the datastore entities, and only filter in memory. This is because filtering in datastore requires we create an index. Probably not needed for now since the number of entities is relatively small, and scanning datastore is relatively fast, but it may be needed next time for course entities. |
NicolasCwy
reviewed
Mar 18, 2024
| CriteriaBuilder cb = HibernateUtil.getCriteriaBuilder(); | ||
| CriteriaQuery<Instant> cq = cb.createQuery(Instant.class); | ||
| Root<UsageStatistics> root = cq.from(UsageStatistics.class); | ||
| cq.select(cb.greatest(root.<Instant>get("createdAt"))); |
There was a problem hiding this comment.
I think this should be changed to startTime since createdAt is what time the entity is created in the SQL DB. UsageStatistics are created one per hour, so this startTime should be unique as well
Fix bug for createdAt
NicolasCwy
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
SELECT MAX(start_time) FROM usage_statistics;and then copy paste the string to the START_TIME_STRING. (Is it possible to do the query in the script?)