Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Add verification migration script #12890

Merged

Conversation

NicolasCwy
Copy link
Contributor

@NicolasCwy NicolasCwy commented Mar 12, 2024

part of #12048

Outline of Solution

  • Separate migration and verification script
  • Fix progress of verification check (Was floored to 0 before multiplying by 100)

@NicolasCwy NicolasCwy self-assigned this Mar 12, 2024
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename MigrateAndVerify script to Migrate only and remove verification script from it?

Btw UsageStats check might fail currently, because new stats are generated since then.

@NicolasCwy NicolasCwy force-pushed the add-verification-migration-script branch 2 times, most recently from 85266ae to 52fe946 Compare March 12, 2024 06:04
@NicolasCwy NicolasCwy force-pushed the add-verification-migration-script branch from 52fe946 to 0d6e741 Compare March 12, 2024 06:04
@NicolasCwy
Copy link
Contributor Author

@ziqing26 The row count script will fail but since the verification scripts are using the migrated Postgresql entity to query datastore, the usage statistic script shouldn't fail even with new statistic objects.

The row count script will write that not all datastore usage statistics are migrated though

Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasCwy NicolasCwy merged commit 3e1718c into TEAMMATES:master Mar 12, 2024
10 of 11 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
@NicolasCwy NicolasCwy deleted the add-verification-migration-script branch April 11, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants