[#11843] Create FeedbackSessionLog entity and cron job action #12895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
reviewed
Mar 13, 2024
src/main/java/teammates/storage/sqlentity/FeedbackSessionLog.java
Outdated
Show resolved
Hide resolved
cedricongjh
reviewed
Mar 13, 2024
FergusMok
requested changes
Mar 13, 2024
src/main/java/teammates/storage/sqlentity/FeedbackSessionLog.java
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
35
| List<FeedbackSessionLogEntry> logEntries = logsProcessor.getFeedbackSessionLogs(null, null, | ||
| startTime.toEpochMilli(), endTime.toEpochMilli(), null); |
There was a problem hiding this comment.
Correctness of this action relies on the ordering added in this method. Would it be better if there's some indication about needing the ordering? I'm thinking getOrderedFeedbackSessionLogs, it's not great, open if there's better suggestions also
There was a problem hiding this comment.
Hmm thats a good point, I think your suggestion should work fine since there is no downside to having it be ordered and in the future if there is a need to retrieve ordered logs the method can be easily found
cedricongjh
reviewed
Mar 14, 2024
FergusMok
approved these changes
Mar 15, 2024
src/test/java/teammates/sqlui/webapi/UpdateFeedbackSessionLogsActionTest.java
Show resolved
Hide resolved
dishenggg
added
s.ToReview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11843
Outline of Solution
Create FeedbackSessionLog Entity
Create UpdateFeedbackSessionLogsAction