[#12048] Migrate FeedbackMsqQuestionE2ETest #12904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiquu
reviewed
Mar 18, 2024
There was a problem hiding this comment.
hey @dishenggg, looks good so far but I think the test needs to be added to src/e2e/resources/testng-e2e-sql.xml for it to run + data should be loaded into a separate json (see tele msg)
src/e2e/java/teammates/e2e/cases/sql/FeedbackMsqQuestionE2ETest.java
Outdated
Show resolved
Hide resolved
|
@dishenggg can take a look and see why it's failing? thanks! |
|
@weiquu The questions were not sorted properly, fixed it! |
cedricongjh
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Update E2E test to use Sql entities
Edit:
Update
FeedbackMsqQuestion.makeDeepCopy()to useFeedbackMsqQuestionDetails.getDeepCopy()Update
FeedbackQuestionLogic.getFeedbackQuestionsForStudents()to sort the questions by question number