[#12048] V9 migration verification script optimisation - fetch ReadNotifications for account comparison #12905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasCwy
force-pushed
the
eager-load-relation
branch
from
b519f0c
to
595ce27
Compare
NicolasCwy
force-pushed
the
eager-load-relation
branch
from
595ce27
to
88a46ff
Compare
ziqing26
requested changes
Mar 17, 2024
| CriteriaBuilder cb = HibernateUtil.getCriteriaBuilder(); | ||
| CriteriaQuery<teammates.storage.sqlentity.Account> pageQuery = cb.createQuery(sqlEntityClass); | ||
|
|
||
| // sort by createdAt to maintain stable order. |
There was a problem hiding this comment.
Suggested change
| // sort by createdAt to maintain stable order. | |
| // sort by id to maintain stable order. |
NicolasCwy
changed the title
FergusMok
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Context
When comparing the SQL account to its datastore account for verification, multiple select query for each account was executed to get their readNotifications. This was be because the association between accounts and readNotifications is lazy.
Outline of Solution
Reduce readNotification fetches by fetching the data for a page using a single join, reducing the number of joins. (Multiple joins per account to 1 join for a page of accounts)
~1min2s for 10,000 accounts with 2 readNotifications to ~3 seconds
Fetching