Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Remove unnecessary loading of datastore entities in InstructorNotificationsPageE2ETest #12911

Merged
merged 10 commits into from
Mar 27, 2024
Merged

[#12048] Remove unnecessary loading of datastore entities in InstructorNotificationsPageE2ETest #12911

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c747cbb
migrate instructor notif e2e
dishenggg Feb 24, 2024
0fef2d0
Merge branch 'master' into migrate-InstructorNotificationsPageE2ETest
cedricongjh Feb 24, 2024
abd80f2
Merge branch 'master' into migrate-InstructorNotificationsPageE2ETest
dishenggg Mar 18, 2024
8637a4e
Remove unnecessary entities
dishenggg Mar 18, 2024
7f9c865
Revert "Remove unnecessary entities"
dishenggg Mar 18, 2024
7fb3ee2
Remove loading of datastore data
dishenggg Mar 18, 2024
191eb26
Revert "Remove loading of datastore data"
dishenggg Mar 19, 2024
133c665
Remove duplicated entities
dishenggg Mar 19, 2024
03bfdac
Merge branch 'master' into migrate-InstructorNotificationsPageE2ETest
dishenggg Mar 19, 2024
6253ed7
Merge branch 'master' into migrate-InstructorNotificationsPageE2ETest
cedricongjh Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions src/e2e/resources/data/InstructorNotificationsPageE2ETest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
{
"accounts": {
"INotifs.instr": {
"googleId": "tm.e2e.INotifs.instr",
"name": "Teammates Test",
"email": "INotifs.instr@gmail.tmt",
"readNotifications": {
"notification4": "2099-04-04T00:00:00Z"
}
}
},
"courses": {
"typicalCourse1": {
"id": "tm.e2e.INotifs.course1",
Expand Down Expand Up @@ -42,62 +32,5 @@
"sessionLevel": {}
}
}
},
"notifications": {
"notification1": {
"notificationId": "notification1",
"startTime": "2011-01-01T00:00:00Z",
"endTime": "2099-01-01T00:00:00Z",
"createdAt": "2011-01-01T00:00:00Z",
"style": "DANGER",
"targetUser": "GENERAL",
"title": "E2E notif for general users",
"message": "<p>This notification is shown to general users</p>",
"shown": false
},
"notification2": {
"notificationId": "notification2",
"startTime": "2011-02-02T00:00:00Z",
"endTime": "2099-02-02T00:00:00Z",
"createdAt": "2011-01-01T00:00:00Z",
"style": "SUCCESS",
"targetUser": "STUDENT",
"title": "E2E notif for students",
"message": "<p>This notification is shown to students only</p>",
"shown": false
},
"notification3": {
"notificationId": "notification3",
"startTime": "2011-03-03T00:00:00Z",
"endTime": "2099-03-03T00:00:00Z",
"createdAt": "2011-01-01T00:00:00Z",
"style": "SUCCESS",
"targetUser": "INSTRUCTOR",
"title": "E2E notif for instructors",
"message": "<p>This notification is shown to instructors only</p>",
"shown": false
},
"notification4": {
"notificationId": "notification4",
"startTime": "2011-04-04T00:00:00Z",
"endTime": "2099-04-04T00:00:00Z",
"createdAt": "2011-01-01T00:00:00Z",
"style": "WARNING",
"targetUser": "GENERAL",
"title": "E2E read notification",
"message": "<p>This notification has been read by the user</p>",
"shown": false
},
"expiredNotification1": {
"notificationId": "expiredNotification1",
"startTime": "2011-01-01T00:00:00Z",
"endTime": "2011-02-02T00:00:00Z",
"createdAt": "2011-01-01T00:00:00Z",
"style": "DANGER",
"targetUser": "GENERAL",
"title": "E2E expired notification",
"message": "<p>This notification has expired</p>",
"shown": false
}
}
}
Loading