[#12900] Gradle task componentTests should not stop entirely when only one task fails #12963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayasting98
requested changes
Apr 2, 2024
jayasting98
added
s.Ongoing
Co-authored-by: Jay Aljelo Ting <65202977+jayasting98@users.noreply.github.com>
Co-authored-by: Jay Aljelo Ting <65202977+jayasting98@users.noreply.github.com>
ziqing26
added
s.ToReview
jayasting98
added
s.FinalReview
|
Thank you for the approval, let me know if I need to test or add anything else |
|
Hi @emrekenar, could you also help to make the change to the |
|
Hi @weiquu I made the change, it seems to be working fine. Let me know if there is anything else I can do. |
|
@weiquu Just a reminder to review this. It looks fine to me now. I think your comment has been addressed. |
weiquu
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12900
Outline of Solution
After the docker is started, running the code below stops if
integrationTeststask fails../gradlew componentTestsHowever, running the following command prevents stopping before all
componentTeststasks finish../gradlew componentTests --continueNote that if
unitTeststask is completed before, to run it again, either the build folder should be cleaned with./gradlew cleanor--rerun-tasksflag should be passed as well.Also note that
./gradlew componentTests jacocoReport --continuedoesn't work. Instead,./gradlew jacocoReportcommand should be executed separately.In this commit, the
--continueflag is added in github workflows and the documentation is updated.