-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11843] Update front end for session activity logs #12973
[#11843] Update front end for session activity logs #12973
Conversation
src/web/app/pages-session/session-submission-page/session-submission-page.component.ts
Show resolved
Hide resolved
src/main/java/teammates/ui/webapi/CreateFeedbackSessionLogAction.java
Outdated
Show resolved
Hide resolved
src/web/app/pages-session/session-submission-page/session-submission-page.component.ts
Show resolved
Hide resolved
src/web/app/pages-session/session-result-page/session-result-page.component.ts
Outdated
Show resolved
Hide resolved
...es-instructor/instructor-student-activity-logs/instructor-student-activity-logs.component.ts
Show resolved
Hide resolved
@dishenggg Could you also attach screenshots of the new buttons as part of documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work thus far, some comments!
src/main/java/teammates/ui/webapi/GetFeedbackSessionLogsAction.java
Outdated
Show resolved
Hide resolved
src/main/java/teammates/ui/webapi/UpdateFeedbackSessionLogsAction.java
Outdated
Show resolved
Hide resolved
src/it/java/teammates/it/ui/webapi/CreateFeedbackSessionLogActionIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work on this!
@dishenggg Great job, I've tried it on staging and it looks good 👍 @cedricongjh and I were discussing to lower the cron job from an hour to 15 minutes. Also, could you add a small disclaimer for instructors to the View Logs page about the 15 minute logging delay? |
Small regression bug that's not on prod now firefox_wLXVGKNZuO.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 Thanks for making the changes
Part of #11843
Outline of Solution
Todo:
Newly added buttons