Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11843] Update front end for session activity logs #12973

Merged
merged 65 commits into from Apr 13, 2024

Conversation

dishenggg
Copy link
Contributor

@dishenggg dishenggg commented Mar 29, 2024

Part of #11843

Outline of Solution

  • Update frontend to pass student/session id as param to logs related actions

Todo:

  • Show all logs in time range
  • Change log status to show log type
  • Provide access to student activity log page

Newly added buttons

image
image

@dishenggg dishenggg self-assigned this Apr 5, 2024
@FergusMok
Copy link
Contributor

@dishenggg Could you also attach screenshots of the new buttons as part of documentation?

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work thus far, some comments!

Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work on this!

@FergusMok
Copy link
Contributor

@dishenggg Great job, I've tried it on staging and it looks good 👍

@cedricongjh and I were discussing to lower the cron job from an hour to 15 minutes.
This will help reduce the delay for instructors before they can view the logs.
Also, it'll reduce out-of-memory errors ingetOrderedFeedbackSessionLogs if there ever turns out to be many students accessing TEAMMATES at once.

Also, could you add a small disclaimer for instructors to the View Logs page about the 15 minute logging delay?

@FergusMok
Copy link
Contributor

Small regression bug that's not on prod now

firefox_wLXVGKNZuO.mp4

Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Thanks for making the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants