Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate InstructorStudentListPageE2ETest #13014

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

cedricongjh
Copy link
Contributor

Part of #12048

Outline of Solution
Migrate InstructorStudentListPageE2ETest
Create InstructorStudentListPageSql, as the previous page object had Map and Collections which would result in type erasure if methods were duplicated for the SQL entities

@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Apr 12, 2024
@cedricongjh cedricongjh requested a review from weiquu April 12, 2024 19:34
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziqing26 ziqing26 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Apr 13, 2024
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu merged commit 4aa2af7 into TEAMMATES:master Apr 18, 2024
11 checks passed
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants