[#12048] Migrate instructor home page e2e test #13016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct params to fsDb.getSoftDeletedFeedbackSession
ziqing26
approved these changes
Apr 14, 2024
| @@ -111,7 +111,7 @@ public List<FeedbackSession> getFeedbackSessionsForCourseStartingAfter(String co | |||
| * @return null if not found. | |||
| */ | |||
| public FeedbackSession getFeedbackSessionFromRecycleBin(String feedbackSessionName, String courseId) { | |||
| return fsDb.getSoftDeletedFeedbackSession(courseId, feedbackSessionName); | |||
| return fsDb.getSoftDeletedFeedbackSession(feedbackSessionName, courseId); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Return FeedbackSession directly from moveFeedbackSessionToRecycleBin in BinFeedbackSessionAction
Fix verifyAccesible for RestoreFeedbackSesionAction
Add getFeedbackSession methods to BACKDOOR and BaseE2ETestCase
Migrate instructorHomePageE2ETest