Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate committers #13052

Merged
merged 2 commits into from Apr 18, 2024
Merged

[#12048] Migrate committers #13052

merged 2 commits into from Apr 18, 2024

Conversation

ziqing26
Copy link
Contributor

@ziqing26 ziqing26 commented Apr 18, 2024 •
edited by jayasting98

Part of #12048

Outline of Solution

Migrated contributors to committers.

@ziqing26 ziqing26 added s.ToReview The PR is waiting for review(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 18, 2024
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 18, 2024
cedricongjh
cedricongjh approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FergusMok
FergusMok approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

domlimm
domlimm approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@NicolasCwy
Copy link
Contributor

@marquestye @yuanxi1 @mingyuanc @dishenggg @domoberzin @xenosf

Congratulations to our dear mentees
image

@jayasting98 jayasting98 changed the title [#12048] Add committers [#12048] Migrate committers Apr 18, 2024
@ziqing26 ziqing26 merged commit 8ec6989 into TEAMMATES:master Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FergusMok FergusMok FergusMok approved these changes

@domlimm domlimm domlimm approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToReview The PR is waiting for review(s)
Projects
None yet
Milestone
V9.0.0-beta.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ziqing26 @NicolasCwy @FergusMok @domlimm @cedricongjh