[#13102] Admin rejecting account request: give actual account in the email template #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed the missing googleId string from "GOOGLEID NOT FOUND" to "NO_GOOGLEID" as its shorter and the underscores makes it more obvious. Added two tests for setting the existingAccount googleId when there are instructor accounts found, and when there are no instructor accounts found. |
weiquu
approved these changes
Jun 28, 2024
weiquu
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13102
Outline of Solution
Replaces accountRequestEmail with the requesters googleId and add some extra information.
Gets the googleId via an admin search with accountRequestEmail as the searchKey.
If no instructor account is found for that email, it will instead say "GOOGLEID NOT FOUND".
Regarding the fix:
It's possible during development (not sure about live) to accidentally create multiple accounts if the googleId chosen is invalid, resulting in nothing after "TEAMMATES using your Google account:".
The fix goes through all instructors with accountRequestEmail and uses the googleId of the last account with a non blank googleId.