Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13109]-IndexOutOfBoundsException encountered by LogsProcessor #13120

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[#13109]-IndexOutOfBoundsException encountered by LogsProcessor #13120

merged 4 commits into from
Jun 12, 2024

Conversation

Ashwinn11
Copy link
Contributor

@Ashwinn11 Ashwinn11 commented May 23, 2024 •
edited
Loading

Fixes #13109

  • Added a check to ensure the logs list is not empty before accessing its last element.

@github-actions GitHub Actions
Copy link

Hi @Ashwinn11, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

domoberzin
domoberzin approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing tests are most likely not caused by this change, thanks for your contribution

@domoberzin domoberzin added s.FinalReview The PR is ready for final review c.Bug Bug/defect report labels Jun 6, 2024
dishenggg
dishenggg approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dishenggg dishenggg added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jun 8, 2024
@wkurniawan07 wkurniawan07 merged commit ec1f276 into TEAMMATES:master Jun 12, 2024
11 checks passed
@Ashwinn11 Ashwinn11 deleted the fix-13109 branch June 12, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andy-W-Developer Andy-W-Developer Andy-W-Developer left review comments

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

@dishenggg dishenggg dishenggg approved these changes

@domoberzin domoberzin domoberzin approved these changes

Assignees

@Ashwinn11 Ashwinn11

Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException encountered by LogsProcessor
5 participants
@Ashwinn11 @wkurniawan07 @dishenggg @domoberzin @Andy-W-Developer