Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13122] Added cancel button #13132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CameronMooreGit
Copy link

@CameronMooreGit CameronMooreGit commented Jun 22, 2024

Fixes #13122 Account Request Form: Adding Cancel button

Outline of Solution

The solution to this problem involved adding a hyperlink that redirects the user from the instructor registration page to the home page. The hyperlink has the appearance of a button by using the btn class. I added a style to the submit button to include a margin-right 15px, making a clean-looking gap between the two buttons appear. See below for visual changes:
image

Copy link

Hi @CameronMooreGit, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@CameronMooreGit CameronMooreGit changed the title added cancel button [#13122] Added cancel button Jun 22, 2024
@weiquu
Copy link
Contributor

weiquu commented Jun 29, 2024

@CameronMooreGit do fix the failing tests. You can visit our documentation to find out more about how to update our snapshot tests. In addition, please don't use plain CSS styling in the components - you can use Bootstrap classes instead. This helps to keep our styling consistent

@weiquu weiquu added the s.Ongoing The PR is being worked on by the author(s) label Jun 29, 2024
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Request Form: Adding Cancel button
3 participants