Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin*LogPageActionTest: improve stability #7829 #7830

Merged
merged 2 commits into from Aug 29, 2017
Merged

Admin*LogPageActionTest: improve stability #7829 #7830

merged 2 commits into from Aug 29, 2017

Conversation

whipermr5
Copy link
Member

Fixes #7829

@whipermr5 whipermr5 added the s.Ongoing The PR is being worked on by the author(s) label Jul 24, 2017
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch 3 times, most recently from c0748b9 to 973b250 Compare August 1, 2017 03:46
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch 5 times, most recently from 1cace89 to 97dd3cc Compare August 3, 2017 18:16
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch 4 times, most recently from d3bc7f0 to 41714cb Compare August 16, 2017 17:19
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch from 41714cb to b2ff9e2 Compare August 17, 2017 07:34
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch from 4893f0c to 54dbac6 Compare August 28, 2017 03:40
@wkurniawan07
Copy link
Member

@whipermr5 looks like this needs to be finished soon, I have seen many builds (including one in master just this morning) that failed just because of the said test.

@whipermr5 whipermr5 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Aug 29, 2017
@whipermr5 whipermr5 force-pushed the 7829-fix-admin-log-test-threading branch from 54dbac6 to c253468 Compare August 29, 2017 08:39
@whipermr5 whipermr5 assigned whipermr5 and wkurniawan07 and unassigned whipermr5 Aug 29, 2017
wkurniawan07
wkurniawan07 approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated the Travis run 5+ times, and not a single occurrence of said failure to be reported 👍

@damithc damithc added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Aug 29, 2017
@whipermr5 whipermr5 added the e.1 label Aug 29, 2017
@whipermr5 whipermr5 added this to the V5.111 milestone Aug 29, 2017
@whipermr5 whipermr5 merged commit 088c896 into TEAMMATES:master Aug 29, 2017
@whipermr5 whipermr5 deleted the 7829-fix-admin-log-test-threading branch August 29, 2017 16:20
@whipermr5 whipermr5 modified the milestones: V5.111, V5.112 Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damithc damithc damithc approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V5.112
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whipermr5 @wkurniawan07 @damithc