Migrate *Attributes time fields from Date to Instant #8636

[whipermr5]

Fixes #8636

Based on #8629. Commits start from 6768e02.

Script used to migrate timestamps in JSON data:

import json
import os, io
from collections import OrderedDict
from datetime import datetime, timedelta

P_FORMAT = '%Y-%m-%d %I:%M %p UTC'

filenames = [f for f in os.listdir('.') if os.path.isfile(f) and f.endswith('.json')]

for filename in filenames:
    print(filename)
    with open(filename) as file:
        data = json.loads(file.read(), object_pairs_hook=OrderedDict)

    try:
        if not data.get('feedbackResponseComments'):
            continue
    except:
        continue

    for fsKey, fs in data.get('feedbackResponseComments').iteritems():
        for key, val in fs.iteritems():
            if key in ['createdAt', 'lastEditedAt']:
                timestamp = datetime.strptime(fs[key], P_FORMAT)
                fs[key] = timestamp.isoformat() + 'Z'

    with io.open(filename, 'w', encoding='utf8') as file:
        file.write(json.dumps(data, indent=2, separators=(',', ': '), ensure_ascii=False) + '\n')

[tran-tien-dat]

Very nice PR. Just a small comment.

[tran-tien-dat]

Is this change in the logic of the test intentional? The original test does not set this field. Ok, I see that this is for consistency with the test below.

[whipermr5]

The original test coupled it together with formatDateForAdminEmailAttributesTest, which I believe was a mistake.

[tran-tien-dat]

The name doesn't make sense. It should be something like convertToAdminTime

[tran-tien-dat]

LGTM

[darrenwee]

👍